Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ArC - fix CreationalContext handling when used directly with BeanManager #32945

Merged

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented Apr 27, 2023

No description provided.

@mkouba mkouba requested review from Ladicek and manovotn April 27, 2023 09:58
@quarkus-bot quarkus-bot bot added the area/arc Issue related to ARC (dependency injection) label Apr 27, 2023
@Ladicek
Copy link
Contributor

Ladicek commented Apr 27, 2023

For historical reference, this PR fixes @PreDestroy interceptors/callbacks being invoked twice for @Dependent beans, when the dependent bean was created through BeanManager.getReference() and is destroyed through Bean.destroy().

@mkouba mkouba added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Apr 27, 2023
@quarkus-bot
Copy link

quarkus-bot bot commented Apr 27, 2023

✔️ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@mkouba mkouba merged commit 8c3103c into quarkusio:main Apr 27, 2023
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Apr 27, 2023
@quarkus-bot quarkus-bot bot added this to the 3.1 - main milestone Apr 27, 2023
@manovotn
Copy link
Contributor

... when the dependent bean was created through BeanManager.getReference() and is destroyed through Bean.destroy().

Just my favourite way of creating and destroying beans :)

I am a bite late but LGTM and thanks for fixing this!

@gsmet
Copy link
Member

gsmet commented May 2, 2023

@mkouba is this something that we want backported to 3.0.2.Final?

@mkouba
Copy link
Contributor Author

mkouba commented May 2, 2023

@mkouba is this something that we want backported to 3.0.2.Final?

I don't think it's necessary because the problem was only spotted in the TCK runner. @Ladicek @manovotn WDYT?

@Ladicek
Copy link
Contributor

Ladicek commented May 2, 2023

Agree, I don't think we need to backport this.

@manovotn
Copy link
Contributor

manovotn commented May 2, 2023

+1, no need to port this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/arc Issue related to ARC (dependency injection)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants